<AWT Dev> <Awt Dev>  Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10
semyon.sadetsky at oracle.com
Tue Oct 4 13:27:30 UTC 2016
On 10/4/2016 4:05 PM, Sergey Bylokhov wrote:
> Hi, Semyon.
> - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the window.
Not sure that it is true. Display mode is a device attribute. It should
be the same as the one presented in the native system configuration.
> - Is it possible to eliminate check for Unity? I guess that if the size of mode and currentwindow are different then the window should be reshaped unconditionally is unity used or not.
It is not necessary for other Linux OSes because this transitional size
updates happen only on Unity. Since this WM behavior is undocumented I
prefer to have an accurately addressed fix.
> ----- alexander.zvegintsev at oracle.com wrote:
>> Looks fine.
>> On 10/03/2016 07:38 PM, Semyon Sadetsky wrote:
>>> The fix is updated
>>> The root case of the issue is that in Unity the screen window size
>>> location are get updated several times after display mode is
>>> and bounds which are set in line 459 of X11GraphicsDevice class are
>>> overwritten. Since those window updates caused by display mode
>>> are not predictable the solution is changed to set the correct
>>> full-screen size in the ConfigureNotify handler.
>>> On 12/7/2015 2:11 PM, Semyon Sadetsky wrote:
>>>> Please review fix for JDK9:
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8141528
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.00/
>>>> Compiz WM requires override redirect for full-screen window to
>>>> preserve the full size upon display mode switching.
More information about the awt-dev