<AWT Dev> [9] Review Request: 8178971 Uncommon formatting and typos in java.desktop module

Semyon Sadetsky semyon.sadetsky at oracle.com
Wed Apr 19 16:02:02 UTC 2017

On 04/19/2017 10:29 AM, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk9.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8178971
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8178971/webrev.00 
> <http://cr.openjdk.java.net/%7Eserb/8178971/webrev.00>
> Webrev which ignores spaces: 
> http://cr.openjdk.java.net/~serb/8178971/webrev_no_space.00 
> <http://cr.openjdk.java.net/%7Eserb/8178971/webrev_no_space.00>
>  - Two typos were fixed in AbstractMultiResolutionImage.java(incorrect 
> tag) and java/awt/package-info.java("con tainer"instead of "container")
>  - The code formatting was fixed in "module-info.java", it seems that 
> different iterations of modules refresh patches used a different line 
> wrapping and code shifting(4 or 5 spaces)
>  - In java sound there are a few places where we replace tabs to 
> spaces and this caused strange alignment of constants
Same issues can be found in so many classes of java.desktop

grep -rE 
--include \*.java jdk/src/java.desktop | wc -l

2685 !!!

Why you decided to fix only those several?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170419/511477ab/attachment.html>

More information about the awt-dev mailing list