<AWT Dev> [9] Review Request: 8178971 Uncommon formatting and typos in java.desktop module

Semyon Sadetsky semyon.sadetsky at oracle.com
Wed Apr 19 20:38:30 UTC 2017

On 04/19/2017 03:32 PM, Sergey Bylokhov wrote:

>>> Its is unimportant because most of them are not in the public API, 
>>> some of them are aligned intentionally, but if you will find 
>>> something useful feel free to file it file it and fix.
>> I see a lot of such formatting issues (hundreds) in public APIs. Are 
>> you proposing to create bugs per each of them?
>> Why not fix them in this bug? This is very easy and harmless.
> Why hundreds? In the previous email you mention 2500 issues, so feel 
> free to file them and fix.
> I fixed an issues which I found when I reread the specification of the 
> methods and tried to find a typos in it.
In this situation I'd suggest to grep for similar typos in the rest 
code. It is not time consumptive.
>>>> From the descripton of the bug you pretend:
>>>> "Uncommon formatting and typos in java.desktop module"
>>>> Then why only javax.sound is considered? A bug tittle issue?
>>> Did you read the text which were in the first email, which describe 
>>> what things were fixed?
>> Yes, I did. But it doesn't correspond to JIRA's title and description.
> I updated description of the bug.\
When I was reading the JIRA I've decided that the purpose of the bug is 
to search and cleanup all javadoc and formatting issues in java.desktop 
module. Next time please use something like "Several typos and 
formatting issues."...
>>>> But this contradicts to the webrev you've sent because it contains
>> src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java
>> 1655             * @gsee #getAccessibleChild
>> I suggest to grep code for javadoc keywords (@...) typos.
> This is not a public API.

Okay. Looks good.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170419/1dd9852d/attachment-0001.html>

More information about the awt-dev mailing list