<AWT Dev> AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords
goetz.lindenmaier at sap.com
Fri Aug 11 11:57:34 UTC 2017
thanks for looking at this change.
I fixed the copyrights, (I actually had a bug skipping 2015, --> 2015, 2017, in my script).
I also adapted the "summary" and double checked jtreg is parsing this correctly.
(I was not sure with the line break and # comments.)
The test test/java/awt/print/PrinterJob/Margins.java
Just opens a window "No printer found" and terminates as 'passed'
if the printer is missing. So I would prefer to skip the
'printer' key from that test.
From: Baesken, Matthias
Sent: Freitag, 11. August 2017 09:29
To: awt-dev at openjdk.java.net; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: re : AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords
Ø I added more headful tests that are only run on windows. I also added
Ø some @requires os=windows where obvious.
Ø I would appreciate a review!
Hi Götz, not a reviewer but I noticed a few of the files need Copyright year update , for example
Does that one need tag printer as well ?
This test got a very long line in the "summary" of the tagging section, maybe better use 2 lines :
Otherwise looks ok to me .
Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev