<AWT Dev> AWT Dev> [9] Review request for 8163979: [macosx] Chinese text shows as Latin w/ openVanilla input method

Dmitry Markov dmitry.markov at oracle.com
Mon Feb 13 16:18:35 UTC 2017

I am sorry, I sent the incorrect version of the fix, (i.e. http://cr.openjdk.java.net/~dmarkov/8163979/webrev.00/). It releases currenLocale two times.
The correct version is located at http://cr.openjdk.java.net/~dmarkov/8163979/webrev.01/
Could you review the updated fix, please?

> On 13 Feb 2017, at 16:58, Dmitry Markov <Dmitry.Markov at oracle.com> wrote:
> Hello,
> Could you review a fix for jdk9, please?
> 	bug: https://bugs.openjdk.java.net/browse/JDK-8163979
> 	webrev: http://cr.openjdk.java.net/~dmarkov/8163979/webrev.00/
> Problem description:
> If the current keyboard layout is set to non-default value, (e.g. ABC, ABC Extended, etc) during Java launch, the input method functionality is not initialised correctly and may not work for some input methods, (e.g. OpenVanilla input method). The initialisation problems are caused by nativeGetAvailableLocales() function from CInputMethod.m. The function tries to obtain the list of available input method locales using platform API. If the retrieval is failed for some reason, nativeGetAvailableLocales() returns empty list or null.
> Fix:
> The function nativeGetAvailableLocales() should return the list contained the current input method locale, if it cannot retrieve the list of available locales from the platform.
> Thanks,
> Dmitry

More information about the awt-dev mailing list