<AWT Dev> <AWT dev> Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac
ambarish.rapte at oracle.com
Tue Feb 14 08:44:19 UTC 2017
Please include the jtreg tag: @key headful
& also include the bug id: 4009555 from the original test.
From: Sergey Bylokhov
Sent: Monday, February 13, 2017 11:02 PM
To: Manajit Halder
Cc: awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> <AWT dev> Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac
It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.
Thank you for the review comment. Please review the modified code.
On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <HYPERLINK "mailto:sergey.bylokhov at oracle.com"sergey.bylokhov at oracle.com> wrote:
Just one comment, the frame should be disposed if the test fails.
Kindly review the fix for JDK9.
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes.
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
The test was cleaned up and moved from closed to open
Removed applet code
Manual test to automatic test
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev