<AWT Dev> [9] Review Request: 8177841 Some java/awt/Robot tests can be improved

Sergey Bylokhov sergey.bylokhov at oracle.com
Thu Mar 30 19:27:23 UTC 2017

> sun.java2d.win.uiScaleX/Y is only applicable to windows which is likely why the test had 
> @requires (os.family == "windows") even if it was not the right name.
> Now you are running unconditionally with those properties on all platforms which
> seems to be a waste of time.
Yes, if we know that uiScaleX/Y are windows specific then 2 modes out of 5 is noop. But I do not like to exclude them, instead I would like to fuzz the tests by supported/unsupported properties, in the same way as 2d-tests are executed using different supported/unsupprted "sun.java2d.XXX" pipelines.

> On 03/30/2017 12:11 PM, Sergey Bylokhov wrote:
>> Hello,
>> Please review the fix for jdk9.
>> Initially I found a typo in the HiDPIRobotMouseClick.java. It contains the «Dsun.java2d.win.uiScale» option, which should be Dsun.java2d.uiScale or Dsun.java2d.win.uiScaleX/Y.
>> But when I verified the fix, the test fails if executed w/o any options (my system has 125% DPI).
>> So I decided to update it and related HiDPIRobotScreenCaptureTest to validated more modes.
>> - Default(w/o options), useful if the system has some default scale.
>> - scale = 1 is useful when the tests are executed on HiDPI systems.
>> I am not sure why these tests sets the Windows L&F because it uses only awt Frame.  
>> I’ll file a separate bug for HiDPIRobotMouseClick.java + 125% DPI.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8177841 <https://bugs.openjdk.java.net/browse/JDK-8177841>
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8177841/webrev.00 <http://cr.openjdk.java.net/~serb/8177841/webrev.00>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170330/0309f49a/attachment.html>

More information about the awt-dev mailing list