<AWT Dev> RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

Langer, Christoph christoph.langer at sap.com
Fri May 4 14:07:00 UTC 2018


please help reviewing the contribution of the support for the AIX Input Method Editor (IME) in AWT's Input Method Framework.

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201429.1/
Bug: https://bugs.openjdk.java.net/browse/JDK-8201429

I took Ichiroh's initial proposal [1] and tried to integrate it better with existing code. I have split src/java.desktop/unix/classes/sun/awt/X11InputMethod.java into
a) a base class containing the common code: src/java.desktop/unix/classes/sun/awt/X11InputMethodBase.java
b) a specific class for the common Linux/Unixes: src/java.desktop/unix/classes/sun/awt/X11InputMethod.java and
c) a specific class for AIX: src/java.desktop/aix/classes/sun/awt/X11InputMethod.java

The AIX specific additions to the native code of src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c were so much that I decided to add a specific implementation file for AIX: src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod_aix.c. The changes to the former file are some cleanups.

I'm still in the process of testing the changes - but maybe you can run further tests, especially on non-AIX unixes to make sure we didn't break something.

Thanks & Best regards

[1]: http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013869.html

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20180504/a27e8548/attachment.html>

More information about the awt-dev mailing list