<AWT Dev> [11] Review Request: 8202051 Address compilation warnings in libawt with VS2017

Phil Race philip.race at oracle.com
Wed May 30 18:36:23 UTC 2018

The cast of HINSTANCE to int and comparison to 32 needed some checking 
.. no matter whether
the compiler complained or not. Could it be a negative value ? Isn't it 
a pointer ?
The docs here for ShellExcute
seem to say it is safe to do the cast + comparison.

So +1


On 05/26/2018 02:19 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk11.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202051
> Webrev: http://cr.openjdk.java.net/~serb/8202051/webrev.00
> The warnings which were disabled in JDK-8202052[1] are fixed. Note 
> that these warnings were found in debug build only.
>  - warning C4291: one more delete[] operator was added. see [2].
>  - warning C4311/C4302: intermediate cast to the "intptr_t" was added.
> [1] https://bugs.openjdk.java.net/browse/JDK-8202052
> [2] https://msdn.microsoft.com/en-us/library/cxdxz3x6.aspx

More information about the awt-dev mailing list