<AWT Dev> <AWT dev> Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete
dmitry.markov at oracle.com
Fri Oct 12 18:44:13 UTC 2018
There is an inconsistency between the proposed implementation and Apple JDK: if the property applied to the dialog which does not have an owner on the build with your changes it appears as sheet, but on Apple JDK it appears as a window.
I think every frame/dialog inside dispose() method in the regression test should be checked for null-value before usage.
I noticed that the regression test uses Timer API (see createAndShowModalSheet() method). Shall we stop/cancel the timer when “Pass”/“Fail” button is press?
I suppose it is better to declare createAndShowModalSheet() and createAndShowInstructionFrame() as static. In such case the creation of class instance may be omitted.
> On 12 Oct 2018, at 05:36, Manajit Halder <manajit.halder at oracle.com> wrote:
> Hi Dmitry,
> Could you please review this fix related to Modal sheet on Mac OS?
> On 10/10/18 3:33 PM, Manajit Halder wrote:
>> Hi All,
>> Kindly review the fix for JDK12.
>> http://cr.openjdk.java.net/~mhalder/8208543/webrev.00/ <http://cr.openjdk.java.net/%7Emhalder/8208543/webrev.00/>
>> "apple.awt.documentModalSheet" was getting set on the Dialog while its creations, but appearance of Dialog was not changing.
>> Setting "apple.awt.documentModalSheet" on Window after its creation.
More information about the awt-dev