<AWT Dev> OpenJdk11-28-EA JDialog hanging
bourges.laurent at gmail.com
Tue Oct 16 17:15:27 UTC 2018
Could you have a look as this fix is important for IcedTeaWeb + jdk11 ?
The webrev applies to OpenJDK12 but should be backported to 11 ?
TimeFrame for 11.0.2 RDP2: late october, GA late january
Le mar. 16 oct. 2018 à 15:50, Laurent Bourgès <bourges.laurent at gmail.com> a
> Hi Martin,
> Thanks for your test! Great job :-)
> Thanks, your fixes are good.
>> I applied some minor changes for integration:
>> * Renamed to TestSeqEventsMultipleContexts
>> * A bit longer but should describe what this is about
>> * Placed in jdk/java/awt/event/SequencedEvent
>> * Encapsulated the window in TestWindow class
>> * Instead of waiting 1s for windows to show, loop until windows are
>> shown -or the test hard stops-. When I ran in my environment, 1s was not
>> enough. This should make the test more resilent. We still depend on a timer
>> but that is inevitably.
>> * Incremented the time we wait for the TGs to finish. 2s was not enough
>> in my runs. However, we now do frequent checks to finish earlier in the
>> success path.
>> * Calculated expected value in initilization time
>> * Changed a bit how the test finishes
>> * System.exit(0) is a failure for jtreg
>> * We need status -1 for jtreg to detect failures, and will do a hard
>> stop when time expires
>> * Stack traces for the main thread are not much relevant
>> * dispose window to exit gracefully on the success path
>> * Removed unused code (button click action)
>> * Added jtreg tags & copyright
>> Webrev.02 with test integrated:
>> * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.02
> I tested the new TestSeqEventsMultipleContexts:
> - jdk8/9/10: OK
> - jdk11: KO
> - jdk12+patch: OK
> I am not an awt reviewer, but it is OK for me.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev