<AWT Dev> RFR: [12] JDK-8211301: [macos] support full window content options

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Oct 16 19:32:39 UTC 2018

Hi, Alan.

The fix in general looks fine, note that you will need create a CSR for the new properties.
I have a questions about the changes in AWTWindow.nativeSetNSWindowStyleBits()
  - Note that after the fix it will block the current thread, this might cause a deadlock if some code on Appkit will try to access resources blocked by the current thread.

  - The new code below is executed on the current thread, and actually may be executed in parallel with the same code in _deliverMoveResizeEvent() on Appkit:
   1115     if (resized) {
   1116         [AWTToolkit eventCountPlusPlus];
   1117         NSRect frame = ConvertNSScreenRect(env, resizeFrame);
   1118         deliverMoveResizeEvent(env, frame, javaPlatformWindow, NO);
   1119         [AWTWindow synthesizeMouseEnteredExitedEventsForAllWindows];
   1120     }

  - Note that [AWTWindow synthesizeMouseEnteredExitedEventsForAllWindows] will access cocoa components and should be use on Appkit.

I think that you can move this new code to the block above and drop shouldWait.

On 11/10/2018 09:03, Alan Snyder wrote:
> A reminder...
>> Please review the following change to the macOS AWT:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8211301
>> Revision: http://cr.openjdk.java.net/~alans/8211301/webrev.00/
>> This change allows applications on macOS to configure windows to use the full window content view option and the transparent title bar option.
>> If approved, I will need a sponsor…
>> Thank you.
>>   Alan

Best regards, Sergey.

More information about the awt-dev mailing list