<AWT Dev> [13] Review Request: 8223766 Remains of ancient code in AWT initialization

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon May 13 20:46:02 UTC 2019

Hi, Jay.
I deleted unused code inside the "initIds()", but "initIds()" methods itself(even empty) are still called from the java shared code.

On 13/05/2019 06:15, Jayathirth Rao wrote:
> Hi Sergey,
> I see that you have removed content of JNI functions related ti initID's.
> Do we need the structure of these JNI functions, if yes can we add some kind of trace log to say there is no implementation.
> Thanks,
> Jay
>> On 13-May-2019, at 4:40 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>> Hello.
>> Please review code cleanup for JDK 13.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223766
>> Fix: http://cr.openjdk.java.net/~serb/8223766/webrev.00
>> We have a few places in which the "initIDs()" methods initialize native data which are never used.
>> This code remains from the MToolkit and some old part of AWT on Windows. In the fix, this code was removed.
>> Note that some of the initIds() methods became empty, in some future fix I'll try to delete them as well.
>> -- 
>> Best regards, Sergey.

Best regards, Sergey.

More information about the awt-dev mailing list