<AWT Dev> RFR: 8252015: [macos11] java.awt.TrayIcon requires updates for template images

Kevin Rushforth kcr at openjdk.java.net
Fri Dec 4 15:13:15 UTC 2020

On Fri, 4 Dec 2020 14:59:05 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

>> Please check the tests in the .../test/jdk/java/awt/TrayIcon/ folder it looks like some of them fail after the fix:
>> java/awt/TrayIcon/ActionCommand/ActionCommand.java 
>> java/awt/TrayIcon/ActionEventMask/ActionEventMask.java 
>> java/awt/TrayIcon/MouseEventMask/MouseEventMaskTest.java 
>> java/awt/TrayIcon/SecurityCheck/FunctionalityCheck/FunctionalityCheck.java 
>> java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java 
>> java/awt/TrayIcon/TrayIconEvents/TrayIconEventsTest.java 
>> java/awt/TrayIcon/TrayIconMouseTest/TrayIconMouseTest.java 
>> java/awt/TrayIcon/TrayIconPopup/TrayIconPopupTest.java
> The icon delegate was not listening for mouse events -- thanks for catching this. I've restored the `AWTTrayIconView` thing (so that it can handle mouse events) and made it inherit from `NSStatusBarButton` (so that icon painting is delegated to MacOS). The fix is less verbose now. I've also renamed the property `apple.awt.enableTemplateImages` and added an `@implnote` as discussed in the CSR.
> Can we consider the CSR approved btw?

@petermz no, the CSR is not in the Approved state. Once it is, the Skara bot will recognize this and remove the `csr` label such that it will not longer be an Integration Blocker.


PR: https://git.openjdk.java.net/jdk/pull/481

More information about the awt-dev mailing list