<AWT Dev> RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v7]

Phil Race prr at openjdk.java.net
Fri Dec 18 22:29:57 UTC 2020

On Fri, 18 Dec 2020 22:22:33 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > > I guess it should work already in the JNF case? The java exception should be wrapped by the NSException in the JNFCallObjectMethod/etc and unwrapped in the JNF_COCOA_ENTER before exists to the java method?
> > 
> > 
> > That is the pattern I know is there today and I don't think is needed.
> > It can be done but I don't think it needed. I'd prefer to see if we ever have such a situation and deal with it "locally"
> > at the call site.
> No, it is quite useful, and it will be good to preserve it. It is possible to work "locally" when the call site if come from java, but not if we are in the infinite native loop.

an NS exception on the appkit will terminate the app - if unhandled - and probably will even if handled
so I am not sure what is better about that

> > > > So I believe we may end up more (theoretically) robust with my changes than we were before.
> > > > Perhaps they weren't a result of a JNF* call but still it seems improved.
> > > > I am not sure about that.
> > > > I am looking at JNI warnings - not just guessing.
> I am looking at a new code that is not as good as before.

I guess we disagree. I think this is better and simpler.


PR: https://git.openjdk.java.net/jdk/pull/1679

More information about the awt-dev mailing list