<AWT Dev>  Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS
Sergey.Bylokhov at oracle.com
Mon Jan 6 20:34:30 UTC 2020
On 1/6/20 8:41 pm, Philip Race wrote:
> How is this useful given that we disable jtreg failure handlers for the headful tests ?
It is disabled only in mach5 for headful nightly and CI builds, but it is enabled for
other builds, also it is enabled if the headful tests are executed standalone via
"make test", and it could easily be enabled in mach5 for personal jobs(I do this time to time)
> On 12/30/19, 11:33 AM, Sergey Bylokhov wrote:
>> On 12/23/19 9:15 pm, Phil Race wrote:
>>> I am not sure what the right mailing list(s) are for this change.
>>> It definitely isn't a core-libs change. I think build-dev may be better.
>> Previous changes to these configs were discussed here, so I have send it here as well.
>>> I am also unclear when this failure handler is invoked and how all this machinery works.
>>> It is only useful for headful tests and so I'd only want it enabled in such a case.
>>> And we disable the failure handlers in the headful test jobs anyway because they seem
>>> focused on taking pointless core dumps ...> So we need something that can be used with headful tests only and doesn't involve
>>> re-enabling the other handlers.
>> It could be useful for other tests as well and may be able to identify problems such as:
>> - Suggestions "to open under debugger" from the native asserts
>> - Various error dialogs from the OS
>> And it does not spend much resources compared to current handlers.
>>> Also why exclude Windows ? No easy way to get the screenshot ?
>> There is no command-line program that can take a screenshot on windows by default
>>> On 12/11/19 1:00 AM, Sergey Bylokhov wrote:
>>>> Please review the fix for JDK 14.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8233827
>>>> Fix: http://cr.openjdk.java.net/~serb/8233827/webrev.01
>>>> This change adds the "screen capture on the test failure" feature on macOS and Linux.
>>>> - On Linux, it is implemented by the "gnome-screenshot" command(in case of
>>>> multiscreen+xinerama the whole big screen will be saved to the "screen.png" file).
>>>> - On macOS it is implemented by the "screencapture" command, note that I have
>>>> used 1 file per screen, if the number of screens less than 5, other files will be ignored.
Best regards, Sergey.
More information about the awt-dev