<AWT Dev> RFR: 8255800: Raster creation methods need some specification clean up [v2]
serb at openjdk.java.net
Fri Apr 2 21:06:30 UTC 2021
On Thu, 1 Apr 2021 20:27:37 GMT, Phil Race <prr at openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line spec clean up but
>> it didn't take a lot of looking to realize there were many more inconsistencies between spec and implementation.
>> I've spent a lot of time on what is just small number of factory methods in Raster because there are so
>> many possible exceptions and in some cases they rely on other API they call to generate exceptions and
>> these may have not been documented or documented acc. to some long lost behavior.
>> I've mostly tried to ONLY change spec. But I couldn't help myself when some checks were missed that
>> ended up with bizarre and dubious behavior - throwing NegativeArrayIndexException which just about
>> always has to be an internal bug !
>> The supplied test passes on JDK 16 as well as this code, because the (relatively) small number of
>> cases where JDK 16 threw NegativeArrayIndexException are caught and allowed only for releases < 17
>> So where you see those in the test it corresponds to the behavioral changes from NegativeArrayIndexException
>> to IllegalArgumentException.
>> JCK conformance tests still pass so they must not test those conditions.
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 8255800: Raster creation methods need some specification clean up
Marked as reviewed by serb (Reviewer).
More information about the awt-dev