<AWT Dev> RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

rajat mahajan github.com+79671271+rajamah at openjdk.java.net
Fri Jul 30 19:48:31 UTC 2021

On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on all OS. Added synchronization for focusCnt.
> test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java line 54:
>> 52: public class ButtonGroupLayoutTraversalTest {
>> 53: 
>> 54:     private static final int nx = 3;
> Normally, as per coding standard, for static final modifier, the variable should be named in CAPS...but is there any need of making it final?

Ran test 20 times on all OS and it passed, posted link in JBS. I avoided changing to CAPS to prevent code change noise and final is done since these variable values don't change or are constant throughout the code and we want it that way.


PR: https://git.openjdk.java.net/jdk/pull/4937

More information about the awt-dev mailing list