<AWT Dev> RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v6]
trebari at openjdk.java.net
Fri May 28 13:38:08 UTC 2021
On Fri, 28 May 2021 12:26:31 GMT, Tejpal Rebari <trebari at openjdk.org> wrote:
>> Hi All,
>> Please review the following fix for jdk17.
>> Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full Screen when the System Preference -> General -> Prefer Tabs is set to "Full Screen". It is also freezing in normal screen when Prefer Tabs is set to "Always".
>> It doesn't freeze when the Prefer tabs is set to "never".
>> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS prior to bigSur(11)
>> (in the AWTWindow.m file), so the issue is not seen in mac os 10.13 10.14 and 10.15.
>> From MacOS 11 onwards this value is set to 1/YES and the issue is seen.
>> This issue can also be reproduced in MacOS 10.15 by setting setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
>> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release staring from 10.12.
>> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default value changed in macos11.
>> Test : Added a manual test and tested on MacOS 10.15 and 11.
>> All the internal tests run are green.
> Tejpal Rebari has updated the pull request incrementally with one additional commit since the last revision:
> addressed review comments
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 131:
> 130: // This system property is used in javafx as well
> 131: public static final String MAC_OS_TABBED_WINDOW = System.getProperty("jdk.allowMacOSTabbedWindows");
need to add doPrivileged here
More information about the awt-dev