<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html;
      charset=windows-1252">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>ok..looks good to me.<br>
    </p>
    Regards<br>
    Prasanta<br>
    <div class="moz-cite-prefix">On 06-Feb-19 2:49 PM, Manajit Halder
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:39149A1B-D632-43FA-ABF2-27775C91AB3B@oracle.com">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      Hi Prasanta,
      <div class=""><br class="">
      </div>
      <div class="">Thanks for your review comment. Please find my reply
        inline to your comments.</div>
      <div class="">Updated webbed: <a
          href="http://cr.openjdk.java.net/%7Emhalder/8207938/webrev.01/"
          class="" moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8207938/webrev.01/</a></div>
      <div class=""><br class="">
      </div>
      <div class="">Regards,</div>
      <div class="">Manajit<br class="">
        <div><br class="">
          <blockquote type="cite" class="">
            <div class="">On 05-Feb-2019, at 3:49 PM, Prasanta Sadhukhan
              <<a href="mailto:prasanta.sadhukhan@oracle.com"
                class="" moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <meta http-equiv="Content-Type" content="text/html;
                charset=windows-1252" class="">
              <div text="#000000" bgcolor="#FFFFFF" class="">
                <p class="">Hi Manajit,<br class="">
                </p>
                I see that IconObserver object is used in
                updateNativeImage()<br class="">
                <span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">209         CImage cimage = CImage.getCreator().createFromImage(image, observer);
 210         boolean imageAutoSize = target.isImageAutoSize();
</span></div>
            </div>
          </blockquote>
          <div><br class="">
          </div>
          <span class="Apple-tab-span" style="white-space:pre">       </span>target
          is already checked for null in imageUpdate method callback and
          hence null check not required in updateNativeImage() method.
          If target is null then CTrayIcon constructor is called and
          target is set again. <br class="">
          <blockquote type="cite" class="">
            <div class="">
              <div text="#000000" bgcolor="#FFFFFF" class=""><span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">
If there is an invalid tray icon target, then wouldn't it cause NPE @210 also? 
</span><br class="">
                <span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class=""><span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">211         cimage.execute(imagePtr -> {

can cimage be null? in that case 211 can cause NPE too?
</span></span></div>
            </div>
          </blockquote>
          <div><br class="">
          </div>
          <span class="Apple-tab-span" style="white-space:pre">       </span>Yes
          it might, added null check.<br class="">
          <blockquote type="cite" class="">
            <div class="">
              <div text="#000000" bgcolor="#FFFFFF" class=""><span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class=""><span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">
</span>Also, I see that target is made null during dispose(), can you check is it null because TrayIcon is disposed?

</span></div>
            </div>
          </blockquote>
          <span class="Apple-tab-span" style="white-space:pre">       </span>Yes,
          TrayIcon is disposed and set to null when TrayIcon image is
          removed from the System tray. TrayIcon is re-initialized when
          TrayIcon image is added to System tray if it is null.</div>
        <div><br class="">
        </div>
        <div><br class="">
        </div>
        <div>
          <blockquote type="cite" class="">
            <div class="">
              <div text="#000000" bgcolor="#FFFFFF" class=""><span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">Regards
Prasanta
</span><span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class=""></span>
                <div class="moz-cite-prefix">On 05-Feb-19 3:21 PM,
                  Manajit Halder wrote:<br class="">
                </div>
                <blockquote type="cite"
                  cite="mid:B0F6B0BB-B769-446C-8DA9-7CEE38B113AB@oracle.com"
                  class="">
                  <meta http-equiv="Content-Type" content="text/html;
                    charset=windows-1252" class="">
                  <div class="">Hi All,</div>
                  <div class=""><br class="">
                  </div>
                  <div class="">Please review the fix for JDK13.</div>
                  <div class=""><br class="">
                  </div>
                  <div class="">Bug:</div>
                  <div class=""><a
                      href="https://bugs.openjdk.java.net/browse/JDK-8207938"
                      class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8207938</a></div>
                  <div class=""><br class="">
                  </div>
                  <div class="">Webrev:</div>
                  <div class=""><a
                      href="http://cr.openjdk.java.net/%7Emhalder/8207938/webrev.00/"
                      class="" moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8207938/webrev.00/</a></div>
                  <div class=""><br class="">
                  </div>
                  <div class="">Fix:</div>
                  <div class="">Problem occur while trying to update
                    native image with invalid tray icon target in the
                    imageUpdate callback.</div>
                  <div class=""><br class="">
                  </div>
                  <div class="">Regards,</div>
                  <div class="">Manajit</div>
                </blockquote>
                <br class="">
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
    </blockquote>
    <br>
  </body>
</html>