<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
+1<br>
<br>
Regards,<br>
Alexey<br>
<br>
<div class="moz-cite-prefix">On 13/12/2019 12:25, Dmitry Markov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4890E737-DEBD-4AF4-96BA-69CDDFC57EE8@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Hi Sergey,
<div class=""><br class="">
</div>
<div class="">The fix looks good to me.</div>
<div class=""><br class="">
</div>
<div class="">Assume that this one and the fix for 8235739 [1]
will be integrated together to avoid test failure on Windows
platform.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Dmitry </div>
<div class=""><br class="">
</div>
<div class="">[1] - <a
href="https://bugs.openjdk.java.net/browse/JDK-8235739"
class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8235739</a><br
class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 11 Dec 2019, at 22:11, Sergey Bylokhov <<a
href="mailto:sergey.bylokhov@oracle.com" class=""
moz-do-not-send="true">sergey.bylokhov@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">I am sorry, I have uploaded it
from one system, and then accidentally removed</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">it by synchronization from another
system. webrev is accessible now.</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">On 12/11/19 9:58 am, Phil Race
wrote:</span><br style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<blockquote type="cite" style="font-family: Helvetica;
font-size: 12px; font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; text-decoration: none;"
class="">Maybe Sergey forgot to post it.<br class="">
-phil.<br class="">
On 12/11/19 1:53 AM, Prasanta Sadhukhan wrote:<br
class="">
<blockquote type="cite" class=""><br class="">
Hi Dmitry,<br class="">
<br class="">
It seems that webrev is not accessible anymore, but I
guess it will be good if both the fix can be clubbed
together.<br class="">
<br class="">
Regards<br class="">
<br class="">
Prasanta<br class="">
<br class="">
On 11-Dec-19 3:15 PM, Dmitry Markov wrote:<br class="">
<blockquote type="cite" class="">Hi Prasanta,<br
class="">
<br class="">
I guess the NPE, you observed, is already addressed
by <a
href="https://bugs.openjdk.java.net/browse/JDK-8235739"
class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8235739</a> (which
is on review now, see <a
href="http://mail.openjdk.java.net/pipermail/awt-dev/2019-December/015621.html"
class="" moz-do-not-send="true">http://mail.openjdk.java.net/pipermail/awt-dev/2019-December/015621.html</a>).<br
class="">
Can you try with fix for 8235739, please?<br
class="">
<br class="">
Thanks,<br class="">
Dmitry<br class="">
<br class="">
<blockquote type="cite" class="">On 11 Dec 2019, at
09:16, Prasanta Sadhukhan <<a
href="mailto:prasanta.sadhukhan@oracle.com"
class="" moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a><span
class="Apple-converted-space"> </span><<a
href="mailto:prasanta.sadhukhan@oracle.com"
class="" moz-do-not-send="true">mailto:prasanta.sadhukhan@oracle.com</a>>>
wrote:<br class="">
<br class="">
Hi Sergey,<br class="">
<br class="">
The regression test fails for me on windows with
NPE<br class="">
<br class="">
java.lang.NullPointerException<br class="">
<span class="Apple-tab-span" style="white-space: pre;"> </span>at
java.desktop/sun.awt.windows.WComponentPeer.getGraphics(WComponentPeer.java:582)<br
class="">
<span class="Apple-tab-span" style="white-space: pre;"> </span>at
java.desktop/java.awt.Component.getGraphics(Component.java:3124)<br
class="">
<span class="Apple-tab-span" style="white-space: pre;"> </span>at
GetGraphicsStressTest.lambda$test$2(GetGraphicsStressTest.java:63)<br
class="">
<span class="Apple-tab-span" style="white-space: pre;"> </span>at
java.base/java.lang.Thread.run(Thread.java:833)<br
class="">
Probably we need to do a null check there in
windows too.<br class="">
<br class="">
Regards<br class="">
Prasanta<br class="">
On 11-Dec-19 1:02 AM, Sergey Bylokhov wrote:<br
class="">
<blockquote type="cite" class="">Hello.<br
class="">
Please review the fix for JDK 14.<br class="">
<br class="">
Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8235638"
class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8235638</a><br
class="">
Fix: <a
href="http://cr.openjdk.java.net/~serb/8235638/webrev.00"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~serb/8235638/webrev.00</a><br
class="">
<br class="">
I have found a root cause of intermittent
failures of some stress tests in the JDK on
macOS.<br class="">
Such tests usually show/hide a lot of frames,
and fails because of NPE in the<br class="">
LWWindowPeer.getOnscreenGraphics()<br class="">
The reason is incorrect null check. We should
read the surfaceData to the local var apply a<br
class="">
null check and then use it, otherwise, the data
may be changed to null after the check.<br
class="">
<br class="">
<br class="">
</blockquote>
</blockquote>
<br class="">
</blockquote>
</blockquote>
</blockquote>
<br style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">--<span
class="Apple-converted-space"> </span></span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">Best regards, Sergey.</span></div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>