<Beans Dev>  Review Request: 8132237 [TEST] Add regression test for JDK-8131342, JDK-8131939, JDK-8132153
alexander.v.stepanov at oracle.com
Wed Jul 29 14:56:23 UTC 2015
Sorry for wasting your time; the push of the test should be postponed as
the key moment of the issue reported in JDK-8131342 is not multiplicity
of the @BeanProperty annotations (as I've hastily supposed) but the
inconsistency of getter return type and setter argument type (see
JDK-8132163 and the updated webrev). It is questionable for now if that
can be considered to be a bug of the annotation or not (as it probably
violates design pattern for the bean properties).
So I'd prefer to postpone the push until the final decision about
JDK-8132163, and then push the test (covering JDK-8132163 as well) or
just omit it.
On 29.07.2015 14:08, Alexander Scherbatiy wrote:
> The fix looks good to me.
> On 7/29/2015 2:09 PM, Alexander Stepanov wrote:
>> Hello Alexander,
>> Thank you for the review; could you please look at the updated
>> version (sorry):
>> the only difference - missing propertyChange event set was added (so,
>> JDK-8132153 is not an issue).
>> On 29.07.2015 12:35, Alexander Scherbatiy wrote:
>>> The fix looks good to me.
>>> On 7/23/2015 2:02 PM, alexander stepanov wrote:
>>>> Could you please review the following fix:
>>>> for the test bug
>>>> Just a single regression test for JDK-8131342, JDK-8131939,
>>>> JDK-8132153 (now failing because of them).
More information about the beans-dev