Need reviewer - two fixes for one

Kelly O'Hair Kelly.Ohair at Sun.COM
Wed Jul 8 00:40:05 UTC 2009

Kelly O'Hair wrote:
> Need reviewer.
> 6855551: java -Xrunhprof crashes when running with classes compiled with 
> targed=7
>   Related to 6855180, assert logic could get segv, investigation found 
> next one.
> 6858127: Missing -DNDEBUG on Linux and Windows native code compiles
>   The C/C++ macro NDEBUG when defined turns assert() macros into 
> nothingness.
>   These assert() macros are for debug builds, not product builds, when
>   an assert fails, it prints out information and typically exits the 
> process.

Just a clarification...  This -DNDEBUG option addition to compile lines
will likely result in a small reduction in code size, and a small performance
improvement on Linux and Windows, perhaps hard to measure.
I will verify that a JDK7 image built this way still serves as a basic
BOOT JDK successfully.
The product builds (optimized non-debug builds) should not rely on
native code standard assert() uses to do 'anything'.


> Webrev:
> -kto

More information about the build-dev mailing list