Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]

Dalibor Topic Dalibor.Topic at Sun.COM
Tue Mar 31 20:30:21 UTC 2009

Tim Bell wrote:
> Review feedback convinced me to reverse that last statement.
> Here is round two - please take a look:
> With these changes the default behavior is as if IMPORT_BINARY_PLUGS=false

Thanks Tim, the change looks good to me.

> Unless the user explicitly sets any of the PLUGS variables:
> Setting these will force IMPORT_BINARY_PLUGS=true

Nice catch. I like the bit making the binary plugs check optional, too.

dalibor topic
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55          
D-20097 Hamburg                 mailto:Dalibor.Topic at
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring

More information about the build-dev mailing list