Request for review: Bug 100054: Make building the Nimbus look 'n' feel optional

Jonathan Gibbons Jonathan.Gibbons at Sun.COM
Fri May 15 16:08:39 UTC 2009

On May 15, 2009, at 9:00 AM, Mark Reinhold wrote:

>> Date: Fri, 15 May 2009 16:30:04 +0100
>> From: Andrew John Hughes <gnu_andrew at>
>> I was thinking this as I read your mail.  It should be easy enough to
>> add this as an #else clause to the existing patch in Sanity.gmk.
>> What's the best way to handle updating the patch, given that the
>> existing patch is a committed changeset?  Do I need to somehow revert
>> the changeset or is a pair of changesets feasible?
> One changeset is best.  You need somehow to revert the changeset
> anyway since it'd need a proper comment, with a Sun bug id, before
> being pushed upstream.  (I just created one for you: 6841728.)
> (I can't resist pointing out that if you were using Mercurial patch
> queues you could just pop to that patch, edit, re-test, finalize,
> and then push the resulting changeset upstream.)
> - Mark


What is your experience with the combination of mq and jcheck?
I like having jcheck enabled as a preextension hook, but that
didn't work well with mq.

-- Jon

More information about the build-dev mailing list