Request for review: Bug 100054: Make building the Nimbus look 'n' feel optional
Max (Weijun) Wang
Weijun.Wang at Sun.COM
Sat May 16 14:53:12 UTC 2009
An mq patch changeset has a "virtual" tag (in self.repo.tags()) which
is not recorded in the .hgtags file.
I think even for an mq patch, jcheck can still check about TAB, CR and
end white spaces.
On May 16, 2009, at 9:50 PM, Jonathan Gibbons wrote:
> Is it not possible to detect that mq is in use/"active" and just
> bail on
> jcheck altogether? i.e. jcheck should surely not apply if you're just
> commiting a patch into your local set of mq patches.
> -- Jon
> On May 15, 2009, at 10:36 PM, Max (Weijun) Wang wrote:
>> I've patched my local jcheck a little to work with mq:
>> 1. If "Reviewed-by" is "nobody", accept it
>> 2. Do not use "self.repo.tags()", bit directly read from
>> the .hgtags file.
>> On May 16, 2009, at 12:16 AM, Mark Reinhold wrote:
>>>> Date: Fri, 15 May 2009 09:08:39 -0700
>>>> From: jonathan.gibbons at sun.com
>>>> What is your experience with the combination of mq and jcheck?
>>> None, so far, since jcheck is disabled in the Jigsaw forest.
>>>> I like having jcheck enabled as a preextension hook, but that
>>>> didn't work well with mq.
>>> Hmm, that bug might get fixed now that the jcheck maintainer
>>> is heavily using mq.
>>> - Mark
More information about the build-dev