Request for review: Bug 100054: Make building the Nimbus look 'n' feel optional

Mark Reinhold mr at
Fri May 29 16:15:19 UTC 2009

> Date: Thu, 21 May 2009 16:51:24 +0100
> From: Andrew John Hughes <gnu_andrew at>

> ...
> Looks like the Contributed-by info is wrong.  I tried adding the line
> as in the example and jcheck choked:
> remote: > Contributed-by: Andrew John Hughes <ahughes at>
> remote:
> remote: Invalid contributor attribution
> remote:
> remote: abort: pretxnchangegroup.0.jcheck hook failed
> The example is Contributed-by: Ben Bitdiddle <ben at>

Right -- as Jon already pointed out, this is a bug in the example.

More the the point, however, you didn't need a Contributed-by line in
your comment since you are the author.  That line is meant to be used
only when the author of the changeset (in hg terms) is not the sole
author of the actual patch.

- Mark

More information about the build-dev mailing list