Another attempt at fixing sane-gcc-compiler

David Holmes David.Holmes at
Fri Dec 3 03:27:59 UTC 2010

Thanks Mike. I'd been struggling to work out why this was failing (as I 
didn't want to pull in your back-out changeset. I was left puzzling why 
this is even checking for something gcc related on Solaris when I'm not 
even building with gcc ???

In any case this looks ok now.


Mike Duigou said the following on 12/03/10 06:11:
> The previous patch (CR 6998016) which attempted to fix the incorrect
> ifdef nesting in the Sanity.gmk sane-gcc-compiler rule ran into a
> problem on 32 bit versions of solaris due to a previously unreported
> error in the use of REQUIRED_GCC_VERSION (which should have been
> REQUIRED_GCC_VER). The fixes for 6998012 and 6998016 were backed out
> temporarily to allow Oracle's internal integration process to
> continue.
> I have now produced an updated webrev which includes the original
> fixes from 6998012 and 6998016 as well as a fix for the blocker
> problem on 32-bit solaris.
> Please review
> Thanks,
> Mike

More information about the build-dev mailing list