Need reviewer: OpenJDK7 Copyright year updates

John Yeary johnyeary at gmail.com
Tue Dec 28 22:50:23 UTC 2010


Hello Kelly,

Shouldn't the original copyrights remain in place? I see there are changes
that remove Sun and replace it with Oracle on files from 1995. I would
expect that code with changes should include the additional copyright for
2010.

Sincerely,

John Yeary

On Tue, Dec 28, 2010 at 4:37 PM, Kelly O'Hair <kelly.ohair at oracle.com>wrote:

> Need reviewer: OpenJDK7 2010 copyright year changes
>
> Any sources changed in 2010 need to have their copyright year adjusted.
>
> Script used is in the top repository at
> make/scripts/update_copyright_year.sh.
> It finds all changesets created in 2010 and verifies that any sources with
> copyrights mention 2010 adding it if necessary.
>
> 6962318: Update copyright year
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/webrev/<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/webrev/>
>
> The webrev tool created some false 'file adds', not sure whether this is a
> webrev
> bug or a /bin/sh problem on Solaris, but these changes only impact the
> Copyright line.
>
> Easiest to just view the 'hg diff -U 0' results for each repository
> impacted:
>   root:
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jdk7-build-copyright.txt<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/diffs.jdk7-build-copyright.txt>
>   corba:
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.corba.txt<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/diffs.corba.txt>
>   jaxp:
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jaxp.txt<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/diffs.jaxp.txt>
>   jaxws:
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jaxws.txt<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/diffs.jaxws.txt>
>   langtools:
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.langtools.txt<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/diffs.langtools.txt>
>   jdk:
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jdk.txt<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-copyright/diffs.jdk.txt>
>
> This does not include hotspot. I'll be asking the hotspot team to deal with
> that separately.
>
> I know this is a mindless and tedious review. Sorry.
>
> -kto
>



-- 
John Yeary
--
http://javaevangelist.blogspot.com
http://www.johnyeary.com

"Far better it is to dare mighty things, to win glorious triumphs, even
though checkered by failure, than to take rank with those poor spirits who
neither enjoy much nor suffer much, because they live in the gray twilight
that knows not victory nor defeat."
-- Theodore Roosevelt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/build-dev/attachments/20101228/2d68da30/attachment.html>


More information about the build-dev mailing list