Need reviewer: OpenJDK7 Copyright year updates
Dr Andrew John Hughes
ahughes at redhat.com
Wed Dec 29 13:30:28 UTC 2010
On 15:50 Tue 28 Dec , Kelly O'Hair wrote:
> These changes are only adding the year 2010, to the copyright for
> files modified in 2010.
> The "first" year should be preserved.
> The pattern "YEAR1, YEAR2," in the Oracle copyright line is the
> equivalent of the old Sun
> copyright year range "YEAR1-YEAR2".
> So if the file originally was created in 1995, and was last modified
> in 2010, it should say "1995, 2010,".
> Not sure I understand your question. Rebranding sources isn't
> something that generates too many smiles. :^(
I read John's comment as he was expecting something like:
(C) 1995 Sun Microsystems
(C) 2010 Oracle
rather than changing the top one to Oracle and expanding the range.
But of course, Oracle now owns the Sun copyrights so the 1995, 2010
Oracle copyright is valid.
> On Dec 28, 2010, at 2:50 PM, John Yeary wrote:
> > Hello Kelly,
> > Shouldn't the original copyrights remain in place? I see there are
> > changes that remove Sun and replace it with Oracle on files from
> > 1995. I would expect that code with changes should include the
> > additional copyright for 2010.
> > Sincerely,
> > John Yeary
> > On Tue, Dec 28, 2010 at 4:37 PM, Kelly O'Hair
> > <kelly.ohair at oracle.com> wrote:
> > Need reviewer: OpenJDK7 2010 copyright year changes
> > Any sources changed in 2010 need to have their copyright year
> > adjusted.
> > Script used is in the top repository at make/scripts/
> > update_copyright_year.sh.
> > It finds all changesets created in 2010 and verifies that any
> > sources with
> > copyrights mention 2010 adding it if necessary.
> > 6962318: Update copyright year
> > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/
> > webrev/
> > The webrev tool created some false 'file adds', not sure whether
> > this is a webrev
> > bug or a /bin/sh problem on Solaris, but these changes only impact
> > the Copyright line.
> > Easiest to just view the 'hg diff -U 0' results for each repository
> > impacted:
> > root: http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jdk7-build-copyright.txt
> > corba: http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.corba.txt
> > jaxp: http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jaxp.txt
> > jaxws: http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jaxws.txt
> > langtools: http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.langtools.txt
> > jdk: http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright/diffs.jdk.txt
> > This does not include hotspot. I'll be asking the hotspot team to
> > deal with that separately.
> > I know this is a mindless and tedious review. Sorry.
> > -kto
> > --
> > John Yeary
> > --
> > http://javaevangelist.blogspot.com
> > http://www.johnyeary.com
> > "Far better it is to dare mighty things, to win glorious triumphs,
> > even though checkered by failure, than to take rank with those poor
> > spirits who neither enjoy much nor suffer much, because they live in
> > the gray twilight that knows not victory nor defeat."
> > -- Theodore Roosevelt
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the build-dev