Invalid sanity check
kelly.ohair at oracle.com
Tue Oct 19 00:54:55 UTC 2010
On Oct 18, 2010, at 4:30 PM, David Holmes wrote:
> Kelly O'Hair said the following on 10/19/10 03:23:
>> On Oct 17, 2010, at 10:35 PM, David Holmes wrote:
>>> I happened to notice in jdk/make/common/shared/Sanity.gmk:
>>> ifeq ($(PLATFORM), solaris)
>>> ifndef OPENJDK
>>> @if [ -r $(GCC_COMPILER_PATH) ]; then \
>>> ifeq ($(PLATFORM), linux)
>>> Looks to me like there's a misplaced endif there.
>> Not sure I see any misplaced endif. I looked at http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/0613978371d8/make/common/shared/Sanity.gmk
> You need an endif before the "ifeq ($(PLATFORM), linux)". Last time
> I checked the platform can't be both solaris and linux so the
> current arrangement has a heap of "dead code" in it.
I think all the endif' are there, but these lines need to be swapped:
1482 ifeq ($(PLATFORM), solaris)
1483 ifndef OPENJDK
This entire sanity check was meant for building the plugin with a very
old gcc, and none of it
applies to the OPENJDK builds.
>> I do see a rather ugly improperly indented mix of shell if commands
>> and makefile if statements. :^(
>> Or maybe the bad indenting is the TAB character viewing problem. :^(
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the build-dev