Need reviewer: No fastdebug builds by default
kelly.ohair at oracle.com
Thu Feb 3 21:44:44 UTC 2011
On Feb 3, 2011, at 10:41 AM, CHRISTINE.LU at ORACLE.COM wrote:
> webrev looks good.
> RE script takes product or fastdebug as a parameter and pass it to
> if [ $build_variant_arg = "fastdebug" ]; then
> gnumake all SKIP_PRODUCT_BUILD=true $newarg $OP $JUNIT
If this line above is supposed to build fastdebug, you need to change
gnumake all SKIP_PRODUCT_BUILD=true SKIP_FASTDEBUG_BUILD=false
$newarg $OP $JUNIT
> elif [ $build_variant_arg = "product" ]; then
> gnumake all SKIP_FASTDEBUG_BUILD=true $newarg $OP $JUNIT
The above is fine.
> gnumake all $newarg $OP $JUNIT
If this line above is supposed to build both, you need to change it to:
gnumake all SKIP_FASTDEBUG_BUILD=false $newarg $OP $JUNIT
> Instead of settting SKIP_FASTDEBUG_BUILD=false,
> does setting SKIP_PRODUCT_BUILD=true (first if condition) cause none
> of product and fastdebug get built?
You can make these changes anytime too, won't hurt the current
> David Katleman (Oracle) wrote:
>> Looks fine Kelly.
>> Kelly O'Hair wrote:
>>> Need reviewer: No fastdebug builds by default
>>> One word change. Default builds from the root will be faster due
>>> to not building the fastdebug images.
>>> This change is in the open repository but will only impact our
>>> closed jdk builds.
>>> Currently when building the openjdk from the top of the forest, it
>>> only builds one image, the so
>>> called "product" image. This change does the same for closed jdk7
>>> FYI.. The fastdebug builds are built with slightly lower native
>>> compiler optimization levels,
>>> all assert checking enabled, and include more debug information.
>>> The java classes may also
>>> include local variable debugging information. These are mostly for
>>> developers but can be used
>>> to isolate runtime issues in a jdk.
>>> Anyone wanting both builds or the old behavior would need to use:
>>> make SKIP_FASTDEBUG_BUILD=false
>>> 7014634: By default, only build the product bits with a closed jdk
>>> build (like openjdk does)
More information about the build-dev