Reviewer needed: building langtools on a Mac
Dr Andrew John Hughes
ahughes at redhat.com
Fri Feb 11 15:09:11 UTC 2011
On 16:38 Thu 10 Feb , Gary Meyer wrote:
> On Feb 9, 2011, at 6:48 PM, Jonathan Gibbons wrote:
> > Build folk,
> > The following fix should make it possible to (again) build langtools on a Mac.
> > Dan Smith reports:
> > - When building the GenStubs in OS X, the Java 6 tools classes are in classes.jar, and this shadows $build.bootstrap.dir, which appears in the classpath. This can be fixed with -Xbootclasspath/p.
> > Webrev here:
> > http://cr.openjdk.java.net/~jjg/7018452/webrev/
> > -- Jon
> I don't know if you will accept me as a code reviewer, but I'm the Java Build Engineer at Apple. These code diffs look good to me.
> Gary Meyer
> Java Software Build Engineer
> gary.meyer at apple.com
Personally, I think it's great that someone who knows the platform
has checked over this patch.
More formally, for the commit, I think it depends on if Oracle gave
you an OpenJDK username yet :-) AFAIK, the 'Reviewed-by' field in
commits has to contain OpenJDK usernames. See the (incomplete)
developer's guide at http://openjdk.java.net/guide/producingChangeset.html
This may or may not be checked by the jcheck extension Oracle run
on commits. Given it's proprietary, we really don't know what it does.
Jon, FWIW, I also think the patch looks fine.
Hope that helps,
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the build-dev