Request for review (M) 7017824: Add support for creating 64-bit Visual Studio projects

Kelly O'Hair kelly.ohair at oracle.com
Fri Feb 11 16:03:06 UTC 2011


Looks fine.

-kto

On Feb 11, 2011, at 3:11 AM, Staffan Larsen wrote:

> This change has some small makefile-changes. Please review.
>
> Thanks,
> /Staffan
>
> From: Staffan Larsen
> Sent: den 10 februari 2011 16:07
> To: hotspot-dev at openjdk.java.net
> Subject: Re! quest for review (M) 7017824: Add support for creating  
> 64-bit Visual Studio projects
>
> http://cr.openjdk.java.net/~sla/7017824/webrev.00/
>
> The current make\windows\create.bat script can only create visual  
> studio projects for 32-bit targets (Win32), it should also be  
> possible to create 64-bit targets (x64).
>
> This fix generates two different project files, one for 32-bit  
> target and one for 64-bit targets. While it would be great to have  
> both targets in the same project, the current tools are not written  
> in a way that makes it easy to fix this. The simple solution is two  
> different projects: vs-i486\jvm.vcproj and vs-amd64\jvm.vcproj.
>
> The create.bat script will dete! ct which target to create by  
> checking which version of the cl.exe compiler is in the PATH.
>
> I have also removed the define of MSC_VER when invoking the  
> complier. Instead the define _MSC_VER is used, which is defined by  
> the compiler.
>
> Thanks,
> /Staffan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/build-dev/attachments/20110211/68cd0d04/attachment.html>


More information about the build-dev mailing list