jdk/src/solaris - time to re-visit it?
Alan.Bateman at oracle.com
Thu Nov 24 10:11:51 UTC 2011
On 23/11/2011 20:48, David Holmes wrote:
> It's definitely tricky (lots of refactoring needed) but it definitely
> needs to be done at some point - however I think we already missed the
> opportunity to do this before integrating the BSD and MacOSX code
> (same on the VM side)
I've often wondered how disruptive it would be if src/solaris were
renamed to src/unix (like Phil, I view src/solaris tree as the unix
tree). Clearly it would make it more awkward to move patches between jdk
versions, and it would cause everyone with in-flight patches to re-base.
If we did rename it then the ifdef <platform> code could stay. Over time
(probably a long time) we could chip away at the refactoring. With the
new build then the direction is to move to be based on capabilities so
we're going to be re-visiting this code anyway.
The immediate benefit of renaming is that it would allow us to move the
Solaris and Linux specific source files out of the src/unix tree into
src/<platform> directories. That would eliminate the need for some of
the filtering in the build and would also allow us sort out some name
conflict issues that we have in several places
(UNIXProcess.java.<platform> for example).
More information about the build-dev