Review Request: Build-infra M1

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Apr 4 15:07:54 UTC 2012


We have also updated the user guide, which is available at http://openjdk.java.net/projects/build-infra/guide.html.

The guide now also includes an FAQ. I'm still working on adding more Qs and As as discussed here on the list to it. If you have any questions that you'd like to see answered in it, feel free to let me know. 

/Magnus

4 apr 2012 kl. 16:41 skrev Erik Joelsson <erik.joelsson at oracle.com>:

> One final review update. Cleanup of configure help output and make help target in root repo.
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-root-new.03/
> 
> /Erik
> 
> On 2012-04-03 11:59, Erik Joelsson wrote:
>> 
>> Fixed these comments and posted new webrevs:
>> 
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-corba-new.02/
>> 
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-new.02/
>> 
>> (Tried making a single webrev but my forest extension isn't working that well)
>> 
>> /Erik
>> 
>> On 2012-03-30 20:08, Kelly O'Hair wrote:
>>> 
>>> Corba Makefile says:  45 # Thus we force the target bytecode to 6.
>>> But I think 6 should be 7, or better yet  "...the
>>>             boot
>>> 
>>>             jdk target bytecode."
>>> 
>>> 
>>>             
>>> 
>>>           
>>> Everything else looks ok to
>>>             me.
>>> 
>>> -kto
>>> 
>>> 
>> 
>> On 2012-03-30 15:19, Jonathan Gibbons wrote:
>>> 
>>> langtools makefile...
>>> 
>>> line 55 typo in comment "ony"
>>> 
>>> line 57 grammar in comment "list of to be created"
>>> 
>>> The Swedish examples are somewhat silly since there are no swedish properties files.
>>> 
>>> The comments on line 92--94 are inaccurate: javac is only build twice, not three times.
>>> 
>>> line 130: grammar, should be either "strip them of all content" or "strip all content from them"
>>> 
>>> line 168: not clear what "this setup" refers to.
>>> 
>>> -- Jon
>> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/build-dev/attachments/20120404/f660df2a/attachment.html>


More information about the build-dev mailing list