code review request for initial JDK FDS support (7071907)
Dmitry.Samersoff at oracle.com
Tue Apr 10 21:47:21 UTC 2012
Looks good for me.
239 # If Full Debug Symbols is enabled, then we want the same debug and
240 # optimization flags as used by FASTDEBUG. We also want all the
241 # debug info in one place (-xs).
Sorry! I'm later at the party. What is the reason of enforcing certain
optimization level with FDS?
192 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
193 ifeq ($(ZIP_DEBUGINFO_FILES),1)
194 (set -e ; \
195 $(CD) $(OBJDIR) ; \
196 $(ZIPEXE) -q $(PROGRAM).diz $(PROGRAM).map $(PROGRAM).pdb ; \
197 $(RM) $(PROGRAM).map $(PROGRAM).pdb ; \
No fallback on zip error here. No ideas what we should do if zip fails,
so it just a FYI.
On 2012-04-11 01:17, Daniel D. Daugherty wrote:
> Thanks Serguei!
> On 4/10/12 2:51 PM, serguei.spitsyn at oracle.com wrote:
>> It is good.
>> On 4/9/12 1:51 PM, Daniel D. Daugherty wrote:
>>> Coming soon to a JDK repo near you! Full Debug Symbols!
>>> OK, to just a subset of libraries and programs... on Linux and
>>> If you're a Windows fan, the JDK repo has had Full Debug Symbols support
>>> since way back in JDK1.4.1... Now we're trying get Linux and Solaris
>>> caught up...
>>> Runtime Team, we don't have much in the JDK repo, but I tried to cover
>>> our few libraries and programs. Let me know if I missed anything...
>>> Serviceability Team, all of your demos, libraries and programs are
>>> covered... for some reason, updating those seemed like reliving old
>>> times and I didn't think you'd mind... :-)
>>> Here is the webrev URL:
>>> Thanks, in advance, for any review comments.
>>> For those of you that are keeping track of all the FDS
>>> changesets, not everything has hit the various master
>>> repos yet. As a reminder, FDS has to hit the closed
>>> install repo first. The open root and jdk repos along
>>> with the closed deploy repo are in the second wave. And
>>> the hotspot repo, being more Mercurial than his fellow
>>> ghosts, will make his appearance in his own good time
>>> (and via a different set of repos)...
>>> Apologies to Dickens, of course... :-)
Java Hotspot development team, SPB04
* There will come soft rains ...
More information about the build-dev