Request for Review: Remove import of empty JNI header files

Anthony Petrov anthony.petrov at
Wed Apr 25 14:09:04 UTC 2012

Hi Magnus,

The fix looks fine to me.

However, this problem may occur again because most developers use the 
old build system, and as such won't notice the issue. Is there a plan to 
remove the old build system and switch over to the new one?

best regards,

On 4/25/2012 5:44 PM, Magnus Ihse Bursie wrote:
> There are a few files native files in AWT and Java2d, which include 
> generated JNI header files, but the corresponding header files are 
> empty, since the class contains neither native methods nor constants.
> All of them have probably been useful at one point in time, but then the 
> Java code changed and the include became irrelevant, but nobody noticed. 
> (Some of them contains JDK1.0-style, pre-JNI native access...)
> The trouble is, in the new build system, we only generate JNI header 
> files when they actually contains something useful! So these files don't 
> get generated. But then the compiler complains when building the native 
> library, since the #include statements points to non-existent files.
> Webrev:
> /Magnus

More information about the build-dev mailing list