Need reviewer: fixes to prtconf for solaris zones and less execs
david.katleman at oracle.com
Thu Jan 5 00:12:13 UTC 2012
Change looks correct, follows what we discussed.
On 1/4/2012 3:50 PM, Kelly O'Hair wrote:
> Need reviewer: fixes to prtconf for solaris zones and less execs
> Basically this patch, will be made to openjdk6, 7u4, and jdk8:
> diff --git a/make/common/shared/Platform.gmk b/make/common/shared/Platform.gmk
> --- a/make/common/shared/Platform.gmk
> +++ b/make/common/shared/Platform.gmk
> @@ -147,8 +147,8 @@
> # Suffix for file bundles used in previous release
> - # How much RAM does this machine have:
> - MB_OF_MEMORY=$(shell /usr/sbin/prtconf | fgrep 'Memory size:' | expand | cut -d' ' -f3)
> + # How much RAM does this machine have (zones send an error to stderr):
> + MB_OF_MEMORY:=$(shell /usr/sbin/prtconf 2>/dev/null | fgrep 'Memory size:' | expand | cut -d' ' -f3)
> Solaris zones caise prtconf to spit out an error to stderr which we can safely ignore, and this make variable
> should be evaluated just once, so the = was changed to a :=.
> This only applied to Solaris.
> 7127104: Build issue with prtconf and zones, also using := to avoid extra execs
More information about the build-dev