rickard.backman at oracle.com
Thu Jan 19 10:03:47 UTC 2012
thanks for the review.
I've tested with JAVASE_EMBEDDED=true and there is no jfr.jar in
j2sdk-image/jre/lib, the same is true with OPENJDK=true. Running without
those creates the jfr.jar in that directory.
I added another set of ifndef's to get rid of warnings.
The change is here:
On 01/19/2012 01:24 AM, David Holmes wrote:
> This looks okay to me (have you tested setting JAVASE_EMBEDDED?)
> For the record once 7130909 is pushed I'll be looking at moving the JFR
> build rules, and the SE Embedded build rules out of the Open repository.
> On 18/01/2012 6:48 PM, Rickard Bäckman wrote:
>> Please review the updated webrev, David Holmes pointed out that we
>> shouldn't build JFR for the embedded environments.
>> Webrev: http://cr.openjdk.java.net/~rbackman/7115200.u1/webrev/
>> On 01/17/2012 04:26 PM, Rickard Bäckman wrote:
>>> CR7115200: Add Java FlightRecorder phase 1
>>> Makefile changes to enable builds of the JDK with JFR.
>>> Webrev: http://cr.openjdk.java.net/~rbackman/7115200/webrev/
>>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7115200
More information about the build-dev