RFR: 7133124 Remove redundant packages from JAR command line

Rickard Bäckman rickard.backman at oracle.com
Thu Jan 26 12:02:40 UTC 2012

On 01/26/2012 12:50 PM, David Holmes wrote:
> On 26/01/2012 7:44 PM, Rickard Bäckman wrote:
>> We have a problem with some versions of jar reporting errors when trying
>> to run jar cf <some.jar> com/test com/test/foo
>> This fix removes the redundant subdirectories from the command.
>> Webrev is here:
>> http://cr.openjdk.java.net/~rbackman/7133124/webrev/
> Change looks fine, but then so did the original! Will this be handled
> correctly by all versions of the jar command?
> David


thanks for the review.

We, have checked the contents of the version that RE is using (1.6.0_1 
or something like that) and the one JPRT is using (1.6.0_18) and locally 
on my machine (1.7.0) I don't think I'll be able to verify _all_ 
versions of jar. It seems the "faulty" behavior of "jar" was fixed in 
1.6.0_18 which is the first version I could find that didn't cause the 
error on the previous code. I would rather hope that we could try to use 
one and the same version across all kind of builds of the same jdk 
version. It would help to catch this kind of errors earlier...


>> Thanks
>> /Rickard

More information about the build-dev mailing list