RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS
david.holmes at oracle.com
Wed Jul 18 00:16:07 UTC 2012
On 18/07/2012 7:29 AM, Kelly O'Hair wrote:
> On Jul 2, 2012, at 10:07 PM, David Holmes wrote:
>> Second this seems wrong:
>> "$(COMPILE_RMIC)" -classpath ...
>> If COMPILE_RMIC is re-defined as "rmic <some-arg>" then the above will
>> fail to execute. Plus didn't you already handle the spaces-in-paths
>> problem in rules.make when you defined COMPILE_RMIC?
> I think COMPILE_RMIC is already defined to have quotes in it's definition,
> I don't think you need quotes here too.
I'm not sure if you are agreeing with me :) so to be clear. We have:
at present. But if we were to change that to
for example, then
"$(COMPILE_RMIC)" -classpath ...
would not work.
More information about the build-dev