code review request for FDS/aurora bug fix (7168520)

Karen Kinnear karen.kinnear at
Thu May 17 14:24:56 UTC 2012


Code looks good. Thank you for figuring out this work-around.


On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote:

> Greetings,
> This is a code review request for the following P1 bug:
>    7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in
>                b39-2012-05-13_231
> Here is the URL for the webrev:
> This fix has already been reviewed internally and is in the process of
> being pushed to the JDK8 T&L repo. Since the bug impacts our internal
> aurora tool, we're moving very quickly on this issue. If this code
> review request generates any additional changes, then we'll use another
> bug ID to make those changes.
> Gory details below...
> In the original FDS implementation, per-VM libjsig.debuginfo symlinks were
> created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES
> feature is enabled (the default), the jre/lib/<arch>/libjsig.debuginfo
> files are ZIPed into jre/lib/<arch>/libjsig.diz. This makes the per-VM
> libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo
> files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix
> puts a work around in place.
> The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM
> libjsig.diz file. Aurora has no problem with ZIP files. After the work
> around is in place, the default libjsig.diz layout is:
> jre/lib/<arch>/libjsig.diz         - ZIP'ed real libjsig.debuginfo
> jre/lib/<arch>/client/libjsig.diz  - ZIP'ed symlink
>                                     (libjsig.debuginfo -> ../libjsig.debuginfo)
> jre/lib/<arch>/server/libjsig.diz  - ZIP'ed symlink
>                                     (libjsig.debuginfo -> ../libjsig.debuginfo)
> Dan

More information about the build-dev mailing list