Need reviewer - @GenerateNativeHeader
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed May 23 10:57:12 UTC 2012
On 2012-05-23 09:51, Fredrik Öhrström wrote:
> There is no point holding off this push since GenerateNativeHeader annotation
> and uses of it were already pushed long time ago. These are just the finishing
> touches to cater for the conversion of the remaining makefiles.
I think Fredrik has a point here. If the idea of using the
GenerateNativeHeader (without any particular regard to modularization)
is problematic, then we already have a problem since we already have put
in GenerateNativeHeader annotations across the code base.
If this approach is not working, then we need to revert those
annotations. This calls for a separate webrev anyway.
If this approach *is* working, then this change adds no new problems.
So we could avoid stalling this push (which is needed to be able to
continue working on build-infra in the Jigsaw forest) by allowing the
additional GenerateNativeHeaders for now, and then continuing the
discussion if the whole idea of GenerateNativeHeaders really work in the
modularized world, and if not, replace them all with a working solution.
Does that sound OK to you?
More information about the build-dev