Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure
tim.bell at oracle.com
Tue Apr 2 14:30:56 UTC 2013
On 04/02/13 02:54, Alan Bateman wrote:
> On 02/04/2013 10:32, Erik Joelsson wrote:
>> On 2013-03-05 16:14, Erik Joelsson wrote:
>>> On 2013-02-20 15:20, Erik Joelsson wrote:
>>>> Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the
>>>> target bootcycle-images. Also fixing an issue with bootcycle-images
>>>> target that prevented them from creating images.
>>> Discovered some more problems with the bootcycle-images target that
>>> needed to be fixed. A full bootcycle build is still not possible due
>>> to errors like this:
>>> error: cannot f
>>> ind symbol
>>> String zonefile = ZoneInfoFile.getFileName(zonename) +
>> Reminder that this needs to be reviewed. The above error is now
>> verified to be gone.
> This is useful to have and the changes look fine to me (although I
> don't consider myself an expert on the build).
> A small typo in bootcycle-spec.gmk.in, " acocunt" -> "account".
Looks good to me as well.
More information about the build-dev