Support building zero with the new build
erik.joelsson at oracle.com
Tue Apr 9 07:22:14 UTC 2013
On 2013-04-08 21:35, Andrew Hughes wrote:
> ----- Original Message -----
>> On 04/08/2013 03:26 PM, Andrew Hughes wrote:
>>>> I have pushed the changes:
>>>> Thank you everyone for all (very patient) reviews and suggestions!
>>> I'm quite surprised to see this. I was about to give feedback on my
>>> to build with this patch (fortunately, it passed) and yet it's already been
>> I thought I heard you mention on IRC that this built without problems. I
>> am sorry if I misunderstood that or mis-remember. Is there anything I
>> can do to address this (now or in the future)?
> I did, but that's not on record. In future, it'd be worth pinging me to double-check.
Since it's in now, it's in, but if you have anything you would like to
change, we can always open another bug and fix it.
>>> Also, according to http://openjdk.java.net/census#erikj, Erik
>>> isn't a reviewer and I'm not sure there's a final ok from David either
>>> (feel free to drop me a link if there is).
>> The result of the vote was announced, though I am also surprised that
>> the census has not been updated:
> I wasn't even aware there was a vote. If I was, I'd have voted in favour.
Thanks! :) Though until I'm listed on the census page, jcheck won't let
you push changes with me as only reviewer. I will ping the registrar.
>> PGP Key: 66484681 (http://pgp.mit.edu/)
>> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the build-dev