RFR 8010280: jvm.cfg needs updating for non-server builds

David Holmes david.holmes at oracle.com
Wed Apr 17 02:34:40 UTC 2013

On 17/04/2013 3:51 AM, Mandy Chung wrote:
> On 4/15/2013 3:42 PM, David Holmes wrote:
>> FYI updated webrev at same location, removing the dead code Erik spotted.
>> http://cr.openjdk.java.net/~dholmes/8010280/webrev/
> Looks good to me.  Nit: CopyFiles.gmk line 340 - you may want to remove
> the extra space to align with the next line.

Thanks Mandy.

>> I've attached all the generated versions below.
> Thanks for the generated files that are helpful for the review. Have you
> considered adding a simple sanity test, if not present, to validate
> jvm.cfg matches with the vm binaries bundled in JAVA_HOME? Just a
> thought and maybe you can file a RFE to add such a test later if you
> think it's a good idea.

A "simple" sanity test? ;-) This would involve finding all the libjvm's 
in a JRE and extracting their names, then finding and reading the 
jvm.cfg file in the JRE, then invoking the VM with all the possible 
entries in jvm.cfg and using the version string to try and see if the 
right VM was selected (or the right error produced). That sounds like a 
pretty horrible test to write. :(  I think noreg-hard is best for this 
one. :)


> Mandy

More information about the build-dev mailing list