RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Dec 4 17:25:17 UTC 2013


Do you thing hg path default and hg path default-push is still buggy? I
think it's better to use hg when possible.

Also,  you can replace part before = to just .* like

sed -n -e '/^default/s/.*=[\s\t]*\(.*\)$/\1/p'


On 2013-12-04 09:16, Mike Duigou wrote:
> Hello all;
> This change addresses a problem discovered by Dave Pointon.
> http://cr.openjdk.java.net/~mduigou/JDK-8029512/0/webrev/
> If the .hg/hgrc file contains (perfectly legal) spaces around the = sign of an assignment then the current script will fail to correctly read the path definition. This patch corrects the parsing of the hgrc file and also protects against empty results.
> I plan to commit this to the JDK 9 repo first but expect that it should be backported to JDK 8 and JDK 7 repos.
> Mike

Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

More information about the build-dev mailing list