RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file
mike.duigou at oracle.com
Wed Dec 4 17:59:00 UTC 2013
On Dec 4 2013, at 09:25 , Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
> Do you thing hg path default and hg path default-push is still buggy? I
> think it's better to use hg when possible.
I suspect the bug was fixed at some point (It works on the 2.2 and 1.9 versions I tried) but I can't be certain that it won't still be broken on some versions
The problem is that some Solaris 10 machines are still running hg 0.95 (ugh!) and other systems are running versions 1.1-1.3.
> Also, you can replace part before = to just .* like
> sed -n -e '/^default/s/.*=[\s\t]*\(.*\)$/\1/p'
Heh, it would seem that for every sed expression has a more concise form that does the same thing!
> On 2013-12-04 09:16, Mike Duigou wrote:
>> Hello all;
>> This change addresses a problem discovered by Dave Pointon.
>> If the .hg/hgrc file contains (perfectly legal) spaces around the = sign of an assignment then the current script will fail to correctly read the path definition. This patch corrects the parsing of the hgrc file and also protects against empty results.
>> I plan to commit this to the JDK 9 repo first but expect that it should be backported to JDK 8 and JDK 7 repos.
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
More information about the build-dev