RFR: JDK-8029908: jdk 8u5 mac build produces incorrect version string 1.8.0_5

Tim Bell tim.bell at oracle.com
Fri Dec 13 16:24:39 UTC 2013


> Please review this simple little workaround for jdk-update-version. On 
> macosx 10.7, the expr command is broken and the following will not 
> work as on other platforms (or macosx 10.8):
> expr "--with-update-version=05" : '[^=]*=\(.*\)'
> On the other platforms, this will return "05" but on 10.7 it returns 
> "5". Autoconf uses this construct to parse command line parameters. 
> Because of this, we are unable to assign the value "05" to 
> --jdk-update-version.
> Since in the build, we always treat the update version as 2 digits, 
> the simple workaround is to zero pad the value for this variable if it 
> is only one character long.
> Webrev: http://cr.openjdk.java.net/~erikj/8029908/webrev.root.01/

Looks good to me.


More information about the build-dev mailing list